Conversation
ghost
assigned
The `ipld-dag-cbor` module isn't used anywhere, hence remove it as a direct dependency.
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
IIRC, that reference was added in order to allow an easy access to it from the browser instance. As it is a dependency of a dependency (ipld in this case), there is no extra space in the final js-ipfs bundle to allow an easy access to it.
This way, I think we may keep it that way. What do you think @vmx @diasdavid @alanshaw ?
|
@vasco-santos I can see the point for other modules. But I don't think you should ever need direct access to ipld-dag-cbor. And if you do, just bundle it yourself. The problem I see here is that if we give access here, it might even be a different version from what js-ipld is using. Hence I think it would cause more pain than benefits. |
|
I see. And what about |
|
I would say IPLD formats are implementation detail, so I'd also be for removing |
|
I'm closing this one in favour of removing all IPLD Formats: |
2 participants
The
ipld-dag-cbormodule isn't used anywhere, hence remove itas a direct dependency.